[LG-3832] fix(date-picker): add screen reader announcements for date input segment values #3223
+39
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsck
requested review from
Copilot and
stephl3
and removed request for
a team
🦋 Changeset detectedLatest commit: 1df2415 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances accessibility for the date-picker component by adding screen reader announcements when users interact with date input segments. When segment values change, screen readers will announce both the segment type (month, day, year) and the new value.
- Adds screen reader announcements for date input segment value changes
- Uses
VisuallyHiddencomponent witharia-live="polite"for announcements - Improves accessibility feedback for screen reader users
Comment on lines
+215
to
+217
| <VisuallyHidden aria-live="polite" aria-atomic="true"> | ||
| {value && `${segment} ${value}`} | ||
| </VisuallyHidden> |
There was a problem hiding this comment.
The screen reader announcement may be repetitive or noisy. Consider throttling announcements or only announcing when the value actually changes, rather than on every render when a value exists.
Copilot uses AI. Check for mistakes.
|
Size Change: +142 B (+0.01%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
stephl3
reviewed
Oct 14, 2025
Comment on lines
+215
to
+217
| <VisuallyHidden aria-live="polite" aria-atomic="true"> | ||
| {value && `${segment} ${value}`} | ||
| </VisuallyHidden> |
There was a problem hiding this comment.
Part of the acceptance criteria of the ticket mentions not announcing "Selection replaced" although I still see that getting flagged. Is the ticket actually wrong? That does seem like what I would expect
However, something I do think worth looking into is why it's repeating the value when incrementing/decrementing. Is there a particular reason for that?
There was a problem hiding this comment.
Yeah, I think that "selection replaced" makes some sense because the selection is being replaced.
I assumed it was being read twice because we're rendering it visually hidden and multiple renders are occurring on the segment, perhaps twice due to strict mode?
stephl3
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR improves accessibility for the date-picker component by adding screen reader announcements when users interact with date input segments. The enhancement uses the
VisuallyHiddencomponent witharia-live="polite"to announce segment values (month, day, year) as they change, providing better feedback for screen reader users.🎟️ Jira ticket: LG-3832
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes