[LG-5504] feat(input-box): add InputSegment
#3293
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egment component references
|
3 tasks
shaneeza
commented
Nov 7, 2025
Collaborator
Author
There was a problem hiding this comment.
I think i should break these out into smaller files
shaneeza
requested review from
a team,
TheSonOfThomp and
stephl3
and removed request for
a team
3 tasks
Contributor
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
5 tasks
shaneeza
commented
Nov 7, 2025
| * 1 | ||
| * 1970 | ||
| */ | ||
| min: number; |
Collaborator
Author
There was a problem hiding this comment.
Update to minSegmentValue
shaneeza
commented
Nov 7, 2025
| * 12 | ||
| * 2038 | ||
| */ | ||
| max: number; |
Collaborator
Author
There was a problem hiding this comment.
Update to maxSegmentValue
shaneeza
commented
Nov 7, 2025
| step?: number; | ||
|
|
||
| /** | ||
| * Whether the segment should wrap at min/max boundaries |
Collaborator
Author
There was a problem hiding this comment.
need to update this: should only be at the max boundary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR is the second PR in a series of PRs that adds the new
InputBoxpackage and integrates it into the existingDatePickerpackage:InputBoxContext#3290InputBox#3285This PR adds the generic
InputSegmentcomponent to the new @leafygreen-ui/input-box package, which provides reusable input segment functionality for date and time components. The component extracts common logic and UI elements previously embedded in the date-picker package, making it available for use across DatePicker, TimeInput, and other similar components.🎟 Jira ticket: LG-5504
✅ Checklist
For new components
🧪 How to test changes
InputSegmentcomponent renders correctly in their respective stories