Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Java binding and build variants #893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin commented Oct 8, 2024

Description

Following the migration and integration of the mongocrypt Java binding into the mongo-java-driver repository, this PR aims to remove the Java binding and any associated build variants from this repository.

For the time being, we will retain the upload-java task as it supports faster local builds in the mongo-java-driver.

JAVA-5585

@vbabanin vbabanin requested review from jyemin, rozza and a team as code owners October 8, 2024 06:27
@jyemin jyemin requested review from kevinAlbs and removed request for a team October 8, 2024 11:50
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -188,32 +181,6 @@ functions:
params:
file: ${PYMONGO_DIR}/xunit-results/TEST-*.xml

"publish java":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbabanin don't we need this task as it creates the jar that we download?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task publishes the mongodb-crypt artificact to Sonatype, so it's no longer needed, as the code no longer lives here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants