-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-5589: Improve BSON project test coverage #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BorisDog
wants to merge
5
commits into
mongodb:main
Choose a base branch
from
BorisDog:csharp5589
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using FluentAssertions; | ||
| using Xunit; | ||
|
|
||
| namespace MongoDB.Bson.Tests.Exceptions | ||
| { | ||
| public class BsonExceptionTests | ||
| { | ||
| [Fact] | ||
| public void Constructor_with_format_and_args_should_format_message_correctly() | ||
| { | ||
| // Act | ||
| var exception = new BsonException("Error code: {0}, message: {1}", 123, "Test error"); | ||
|
|
||
| // Assert | ||
| exception.Message.Should().Be("Error code: 123, message: Test error"); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Constructor_with_format_and_args_should_handle_empty_args() | ||
| { | ||
| // Act | ||
| var exception = new BsonException("Simple message"); | ||
|
|
||
| // Assert | ||
| exception.Message.Should().Be("Simple message"); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Constructor_with_format_and_args_should_handle_null_args() | ||
| { | ||
| // Act | ||
| var exception = new BsonException("Message with {0}", (object)null); | ||
|
|
||
| // Assert | ||
| exception.Message.Should().Be("Message with "); | ||
| } | ||
| } | ||
| } |
74 changes: 74 additions & 0 deletions
74
tests/MongoDB.Bson.Tests/Exceptions/BsonInternalExceptionTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System; | ||
| using FluentAssertions; | ||
| using Xunit; | ||
|
|
||
| namespace MongoDB.Bson.Tests.Exceptions | ||
| { | ||
| public class BsonInternalExceptionTests | ||
| { | ||
| [Fact] | ||
| public void Constructor_should_initialize_empty_instance() | ||
| { | ||
| // Act | ||
| var exception = new BsonInternalException(); | ||
|
|
||
| // Assert | ||
| exception.Message.Should().Be("Exception of type 'MongoDB.Bson.BsonInternalException' was thrown."); | ||
| exception.InnerException.Should().BeNull(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Constructor_should_initialize_instance_with_message() | ||
| { | ||
| // Arrange | ||
| var message = "Test internal exception message"; | ||
|
|
||
| // Act | ||
| var exception = new BsonInternalException(message); | ||
|
|
||
| // Assert | ||
| exception.Message.Should().Be(message); | ||
| exception.InnerException.Should().BeNull(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Constructor_should_initialize_instance_with_message_and_inner_exception() | ||
| { | ||
| // Arrange | ||
| var message = "Test internal exception message"; | ||
| var innerException = new Exception("Inner exception message"); | ||
|
|
||
| // Act | ||
| var exception = new BsonInternalException(message, innerException); | ||
|
|
||
| // Assert | ||
| exception.Message.Should().Be(message); | ||
| exception.InnerException.Should().BeSameAs(innerException); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Should_inherit_from_bson_exception() | ||
| { | ||
| // Act | ||
| var exception = new BsonInternalException(); | ||
|
|
||
| // Assert | ||
| exception.Should().BeAssignableTo<BsonException>(); | ||
| } | ||
| } | ||
| } |
39 changes: 39 additions & 0 deletions
39
tests/MongoDB.Bson.Tests/Exceptions/BsonSerializationExceptionTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System; | ||
| using FluentAssertions; | ||
| using Xunit; | ||
|
|
||
| namespace MongoDB.Bson.Tests.Exceptions | ||
| { | ||
| public class BsonSerializationExceptionTests | ||
| { | ||
| [Fact] | ||
| public void Constructor_with_message_and_inner_exception_should_initialize_properties() | ||
| { | ||
| // Arrange | ||
| var message = "Test error message"; | ||
| var innerException = new ArgumentException("Inner exception message"); | ||
|
|
||
| // Act | ||
| var exception = new BsonSerializationException(message, innerException); | ||
|
|
||
| // Assert | ||
| exception.Message.Should().Be(message); | ||
| exception.InnerException.Should().BeSameAs(innerException); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BsonSerializationExceptionclass looks exactly likeBsonInternalException. Should we make tests similar as well? Somehow BsonInternalExceptionTests has much more test cases.