GODRIVER-3096 Remove "stats" package dependency #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
codespell failed in pre_commit test because of lorem ipsum string mispelled words in the test strings of internal/cmd/benchmark/operation_test.go |
You can add that file to the exclude regex |
mongodb-drivers-pr-bot
bot
added
dependencies
prestonvasquez
requested review from
prestonvasquez and
matthewdale
and removed request for
prestonvasquez
matthewdale
reviewed
Jun 14, 2024
Co-authored-by: Matt Dale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3096
Summary
The changes in this pull-request answers the ticket GODRIVER-3096 of removing the "github.com/montanaflynn/stats" dependency from the Go driver module. This is done by moving the internal/benchmark code into internal/cmd/benchmark (the only placed where the "stats" package is used) to make the benchmark system its own submodule so it can pull in additional dependencies.
Background & Motivation
PR 1507 (tentatively) removes the need to calculate 90th percentile and standard deviation for RTT samples. Those are the last two "production" use cases for the "github.com/montanaflynn/stats" package in the Go driver. We should remove all other uses of the "stats" package so we can remove it from the Go driver dependencies.