GODRIVER-3096 Fixed perfomance CI break by running benchmark pkg not main #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
dependencies
API Change ReportNo changes found! |
There was a problem hiding this comment.
Reran failed test for 8.0 RHEL test-sharded-auth-ssl-zlib-compression which passed after rerun. LGTM!
timothy-kim-mongo
previously approved these changes
Jul 16, 2024
timothy-kim-mongo
suggested changes
Jul 16, 2024
There was a problem hiding this comment.
Compile Check Error found: [2024/07/15 19:08:02.423] ../../../../../../pkg/mod/github.com/klauspost/[email protected]/zstd/dict.go:492:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
[2024/07/15 19:08:02.423] note: module requires Go 1.20
from Evergreen Patch Error.
It seems from this error that the compress package used at v1.17.8 only works for Go 1.20. I suggest to downgrade the version to github.com/klauspost/compress v1.13.6 on Line 19 of this file used in GODRIVER v1 which is compatible with Go 1.18 or a possible later version that can work with go version 1.18.
There was a problem hiding this comment.
Great catch!
…z/mongo-go-driver into run-benchmark-pkg-not-main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3096
Summary
Downgrade benchmark to minimum supported version Go 1.18, add benchmark to the workspace.
Background & Motivation
The changes made in b524a7e no longer work with the performance CI test. Additionally, we should be using the minimum supported version 1.18.