-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-3285 Allow update to supply sort option. #1797
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,6 +125,7 @@ type ReplaceOneModel struct { | |
Filter interface{} | ||
Replacement interface{} | ||
Hint interface{} | ||
Sort interface{} | ||
} | ||
|
||
// NewReplaceOneModel creates a new ReplaceOneModel. | ||
|
@@ -173,6 +174,14 @@ func (rom *ReplaceOneModel) SetUpsert(upsert bool) *ReplaceOneModel { | |
return rom | ||
} | ||
|
||
// SetSort specifies which document the operation replaces if the query matches multiple documents. The first document | ||
// matched by the sort order will be replaced. This option is only valid for MongoDB versions >= 8.0. The driver will | ||
// return an error if the sort parameter is a multi-key map. The default value is nil. | ||
func (rom *ReplaceOneModel) SetSort(sort interface{}) *ReplaceOneModel { | ||
rom.Sort = &sort | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is taking the address of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fat-fingers... 😅 |
||
return rom | ||
} | ||
|
||
func (*ReplaceOneModel) writeModel() {} | ||
|
||
// UpdateOneModel is used to update at most one document in a BulkWrite operation. | ||
|
@@ -183,6 +192,7 @@ type UpdateOneModel struct { | |
Update interface{} | ||
ArrayFilters []interface{} | ||
Hint interface{} | ||
Sort interface{} | ||
} | ||
|
||
// NewUpdateOneModel creates a new UpdateOneModel. | ||
|
@@ -238,6 +248,14 @@ func (uom *UpdateOneModel) SetUpsert(upsert bool) *UpdateOneModel { | |
return uom | ||
} | ||
|
||
// SetSort specifies which document the operation updates if the query matches multiple documents. The first document | ||
// matched by the sort order will be updated. This option is only valid for MongoDB versions >= 8.0. The driver will | ||
// return an error if the sort parameter is a multi-key map. The default value is nil. | ||
func (uom *UpdateOneModel) SetSort(sort interface{}) *UpdateOneModel { | ||
uom.Sort = sort | ||
return uom | ||
} | ||
|
||
func (*UpdateOneModel) writeModel() {} | ||
|
||
// UpdateManyModel is used to update multiple documents in a BulkWrite operation. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additional
createSort
logic seems unnecessary. Can we do something similar to the "comment" case and just passval
toSetSort
?E.g.