-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-2388 Improved Bulk Write API. #1884
Open
qingyang-hu
wants to merge
13
commits into
mongodb:master
Choose a base branch
from
qingyang-hu:godriver2388v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1309416
GODRIVER-2388 Improved Bulk Write API.
qingyang-hu 4d88edf
GODRIVER-2388 implementation
qingyang-hu d10eff2
updates
qingyang-hu 3489ac8
add `HasVerboseResults` in `ClientBulkWriteResult`
qingyang-hu acca80b
add comments
qingyang-hu fc91428
GODRIVER-3421 Remove the BSON document size validation.
qingyang-hu ce3ed92
fix tests
qingyang-hu 4f9c841
Merge branch 'master' into godriver2388v2
qingyang-hu 89947bd
Align client bulk write API with legacy bulk write.
qingyang-hu ecd4e1a
code polish
qingyang-hu 0a2e7b8
update test case
qingyang-hu b43f6e6
update test case
qingyang-hu 43fb9c2
Clarify logic.
qingyang-hu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -398,7 +398,7 @@ func TestClientSideEncryptionCustomCrypt(t *testing.T) { | |||||
"expected 0 calls to DecryptExplicit, got %v", cc.numDecryptExplicitCalls) | ||||||
assert.Equal(mt, cc.numCloseCalls, 0, | ||||||
"expected 0 calls to Close, got %v", cc.numCloseCalls) | ||||||
assert.Equal(mt, cc.numBypassAutoEncryptionCalls, 2, | ||||||
assert.Equal(mt, cc.numBypassAutoEncryptionCalls, 1, | ||||||
"expected 2 calls to BypassAutoEncryption, got %v", cc.numBypassAutoEncryptionCalls) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Optional: Update error message to match updated assertion.
Suggested change
|
||||||
}) | ||||||
} | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only call it once after the operation.go refactoring.