Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mongodb orchestration evergreen integration testing config #9

Merged
merged 33 commits into from
Dec 4, 2024

Conversation

NathanQingyangXu
Copy link
Contributor

@NathanQingyangXu NathanQingyangXu commented Nov 5, 2024

@NathanQingyangXu
Copy link
Contributor Author

I referred to a couple of driver repos and found the evergreen config from Rust driver repo is the most updated and well-maintained, so I made the changes mainly following its models.

There is a generate_buildvariants.sh script (Rust team has similar stuff but in Rust script) to generate the buildvariant yml file based on the defined MongoDB version + topology permutation.

.evergreen/generate-buildvariants.sh Outdated Show resolved Hide resolved
.evergreen/create-expansions.sh Outdated Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
@jyemin jyemin requested a review from katcharov November 8, 2024 13:18
.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
@jyemin jyemin requested a review from katcharov November 18, 2024 20:42
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review.

.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
@NathanQingyangXu
Copy link
Contributor Author

The testing result uploading seems working fine, as demonstrated at https://spruce.mongodb.com/task/mongo_hibernate_mongodb_v6.0_replicaset_run_test_patch_caf40017b283b003e42ea72ab20ac8abbcb5b38d_673be38c82c0680007fa5999_24_11_19_01_02_08?execution=0&sortBy=STATUS&sortDir=ASC

Also, as can be seen from the checks of this PR, the 3 mongoDB versions testings seem all working fine as well.

jyemin
jyemin previously approved these changes Nov 26, 2024
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided not to use the Java (or Rust, etc.) driver config as a baseline during the catchup meeting, and to review this file independently of what we might have done before, so I have reviewed this in the same way as any other "new code". I have tried to identify issues or conventions related to things being more modern (some of the scripts already do this, which is great), or to things that might have made sense in the driver at one time, but no longer do. For certain conventions, I have proposed some particular approach - we might end up with some other convention, but I think it is important to settle on one, for the sake of consistency.

.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Show resolved Hide resolved
.evergreen/config.yml Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Show resolved Hide resolved
.evergreen/run-test.sh Show resolved Hide resolved
.evergreen/run-test.sh Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
Co-authored-by: Maxim Katcharov <[email protected]>
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

.evergreen/config.yml Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Show resolved Hide resolved
.evergreen/fetch-drivers-tools.sh Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NathanQingyangXu NathanQingyangXu merged commit 1c94e93 into main Dec 4, 2024
@NathanQingyangXu NathanQingyangXu deleted the HIBERNATE-26 branch December 4, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants