-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mongodb orchestration evergreen integration testing config #9
Conversation
I referred to a couple of driver repos and found the evergreen config from Rust driver repo is the most updated and well-maintained, so I made the changes mainly following its models. There is a |
…e and NullAway is bound to compileJava gradle task)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review.
Co-authored-by: Maxim Katcharov <[email protected]>
Co-authored-by: Maxim Katcharov <[email protected]>
The testing result uploading seems working fine, as demonstrated at https://spruce.mongodb.com/task/mongo_hibernate_mongodb_v6.0_replicaset_run_test_patch_caf40017b283b003e42ea72ab20ac8abbcb5b38d_673be38c82c0680007fa5999_24_11_19_01_02_08?execution=0&sortBy=STATUS&sortDir=ASC Also, as can be seen from the checks of this PR, the 3 mongoDB versions testings seem all working fine as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided not to use the Java (or Rust, etc.) driver config as a baseline during the catchup meeting, and to review this file independently of what we might have done before, so I have reviewed this in the same way as any other "new code". I have tried to identify issues or conventions related to things being more modern (some of the scripts already do this, which is great), or to things that might have made sense in the driver at one time, but no longer do. For certain conventions, I have proposed some particular approach - we might end up with some other convention, but I think it is important to settle on one, for the sake of consistency.
Co-authored-by: Maxim Katcharov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
e68a299
to
f162e23
Compare
…k after confirmation with `run_orchestration.sh` authors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
https://jira.mongodb.org/browse/HIBERNATE-26