-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Improve Netty test variants #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,12 +6,12 @@ set -o errexit # Exit the script with error if any of the commands fail | |
# Supported/used environment variables: | ||
# AUTH Set to enable authentication. Values are: "auth" / "noauth" (default) | ||
# SSL Set to enable SSL. Values are "ssl" / "nossl" (default) | ||
# NETTY_SSL_PROVIDER The Netty TLS/SSL protocol provider. Ignored unless SSL is "ssl" and STREAM_TYPE is "netty". Values are "JDK", "OPENSSL", null (a.k.a. "" or '') (default). | ||
# NETTY_SSL_PROVIDER The Netty TLS/SSL protocol provider. Ignored unless SSL is "ssl" and ASYNC_TRANSPORT is "netty". Values are "JDK", "OPENSSL", null (a.k.a. "" or '') (default). | ||
# MONGODB_URI Set the suggested connection MONGODB_URI (including credentials and topology info) | ||
# TOPOLOGY Allows you to modify variables and the MONGODB_URI based on test topology | ||
# Supported values: "server", "replica_set", "sharded_cluster" | ||
# COMPRESSOR Set to enable compression. Values are "snappy" and "zlib" (default is no compression) | ||
# STREAM_TYPE Set the stream type. Values are "nio2" or "netty". Defaults to "nio2". | ||
# ASYNC_TRANSPORT Set the async transport. Values are "nio2" or "netty". | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed the name to match the new TransportSettings class introduced in 5.0 |
||
# JDK Set the version of java to be used. Java versions can be set from the java toolchain /opt/java | ||
# SLOW_TESTS_ONLY Set to true to only run the slow tests | ||
# AWS_ACCESS_KEY_ID The AWS access key identifier for client-side encryption | ||
|
@@ -34,13 +34,14 @@ SSL=${SSL:-nossl} | |
MONGODB_URI=${MONGODB_URI:-} | ||
TOPOLOGY=${TOPOLOGY:-server} | ||
COMPRESSOR=${COMPRESSOR:-} | ||
STREAM_TYPE=${STREAM_TYPE:-nio2} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need to default it since it's already defaulted in |
||
TESTS=${TESTS:-test} | ||
SLOW_TESTS_ONLY=${SLOW_TESTS_ONLY:-false} | ||
|
||
export ASYNC_TYPE="-Dorg.mongodb.test.async.type=${STREAM_TYPE}" | ||
if [ -n "${ASYNC_TRANSPORT}" ]; then | ||
readonly JAVA_SYSPROP_ASYNC_TRANSPORT="-Dorg.mongodb.test.async.transport=${ASYNC_TRANSPORT}" | ||
jyemin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
fi | ||
|
||
if [ "${SSL}" = "ssl" ] && [ "${STREAM_TYPE}" = "netty" ] && [ "${NETTY_SSL_PROVIDER}" != "" ]; then | ||
if [ "${SSL}" = "ssl" ] && [ "${ASYNC_TRANSPORT}" = "netty" ] && [ -n "${NETTY_SSL_PROVIDER}" ]; then | ||
readonly JAVA_SYSPROP_NETTY_SSL_PROVIDER="-Dorg.mongodb.test.netty.ssl.provider=${NETTY_SSL_PROVIDER}" | ||
fi | ||
|
||
|
@@ -128,7 +129,7 @@ echo "Running tests with Java ${JAVA_VERSION}" | |
./gradlew -version | ||
|
||
./gradlew -PjavaVersion=${JAVA_VERSION} -Dorg.mongodb.test.uri=${MONGODB_URI} \ | ||
${MULTI_MONGOS_URI_SYSTEM_PROPERTY} ${API_VERSION} ${GRADLE_EXTRA_VARS} ${ASYNC_TYPE} \ | ||
${JAVA_SYSPROP_NETTY_SSL_PROVIDER} \ | ||
${MULTI_MONGOS_URI_SYSTEM_PROPERTY} ${API_VERSION} ${GRADLE_EXTRA_VARS} \ | ||
${JAVA_SYSPROP_ASYNC_TRANSPORT} ${JAVA_SYSPROP_NETTY_SSL_PROVIDER} \ | ||
-Dorg.mongodb.test.fle.on.demand.credential.test.failure.enabled=true \ | ||
--stacktrace --info --continue ${TESTS} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.