Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace OperatorInterface::getOperator() with OperatorInterface::NAME constant #1541

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Replace OperatorInterface::getOperator() with OperatorInterface::NAME constant #1541

merged 3 commits into from
Dec 3, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Nov 28, 2024

  • Remove the Encode::FlatObject specific encoding by setting null for the operator name.
  • Replace OperatorInterface::getOperator() with OperatorInterface::NAME constant. This doesn't need to be dynamic.

@GromNaN GromNaN requested a review from a team as a code owner November 28, 2024 08:57
@GromNaN GromNaN requested a review from jmikola November 28, 2024 08:57
@GromNaN GromNaN force-pushed the builder-noNameOperator branch from 04d953e to c83e779 Compare November 28, 2024 08:58
@GromNaN GromNaN mentioned this pull request Nov 29, 2024
Merged
2 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 29, 2024
View reviewed changes
src/Builder/Encoder/OperatorEncoder.php Fixed Show fixed Hide fixed
src/Builder/Type/CombinedFieldQuery.php Dismissed Show dismissed Hide dismissed
src/Builder/Type/QueryObject.php Dismissed Show dismissed Hide dismissed
src/Builder/Type/QueryObject.php Dismissed Show dismissed Hide dismissed
src/Builder/Type/QueryObject.php Dismissed Show dismissed Hide dismissed
src/Builder/Type/QueryObject.php Dismissed Show dismissed Hide dismissed
src/Builder/Type/QueryObject.php Dismissed Show dismissed Hide dismissed
src/Builder/Type/QueryObject.php Dismissed Show dismissed Hide dismissed
@GromNaN GromNaN force-pushed the builder-noNameOperator branch from 000e12d to 961f518 Compare December 2, 2024 21:53
@GromNaN
Replace getOperator with Operator::NAME constant
3c9b7cd 
Fix static analysis

Rename noName to wrapObject
@GromNaN
Regenerate files
2c805b6
@GromNaN GromNaN force-pushed the builder-noNameOperator branch from 961f518 to 2c805b6 Compare December 2, 2024 22:00
@GromNaN GromNaN requested a review from jmikola December 2, 2024 22:02
@GromNaN GromNaN force-pushed the builder-noNameOperator branch from 6848b94 to d7a08af Compare December 3, 2024 09:24
@GromNaN GromNaN requested a review from jmikola December 3, 2024 12:14
jmikola
jmikola approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but please correct the comment on private function wrap() before merging.

src/Builder/Encoder/OperatorEncoder.php Outdated Show resolved Hide resolved
@GromNaN GromNaN force-pushed the builder-noNameOperator branch from d7a08af to 9586098 Compare December 3, 2024 16:39
@GromNaN GromNaN enabled auto-merge (squash) December 3, 2024 16:40
@GromNaN GromNaN merged commit 373bbc4 into mongodb:v1.x Dec 3, 2024
31 checks passed
@mongodb-php-bot mongodb-php-bot mentioned this pull request Dec 3, 2024
Merged
@GromNaN GromNaN deleted the builder-noNameOperator branch December 3, 2024 17:13
@mongodb-php-bot mongodb-php-bot mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GromNaN @jmikola