Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Projection operator #1543

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Nov 28, 2024

The class MongoDB\Builder\Projection\ElemMatchOperator was generated by an early version of the lib. But this category of operators was removed, replaced by MongoDB\Builder\Query\ElemMatchOperator.

@GromNaN GromNaN requested a review from jmikola November 28, 2024 14:25
@GromNaN GromNaN requested a review from a team as a code owner November 28, 2024 14:25
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this never documented?

Also, since some of the removed files were auto-generated, is there anything in place to detect that generated files are obsolete? In this case, I noted a configuration file was never removed, so presumably there's no longer anything in place that would produce these files.

@GromNaN
Copy link
Member Author

GromNaN commented Dec 2, 2024

There is nothing to detect generated files that should be removed. I can hack something that deletes all files that contains "THIS FILE IS AUTO-GENERATED. ANY CHANGES WILL BE LOST!" before running the generate command.
The projection operators were removed by mongodb/mongo-php-builder#54.

@GromNaN GromNaN merged commit f9400d9 into mongodb:v1.x Dec 2, 2024
31 checks passed
@GromNaN GromNaN deleted the builder-projection branch December 2, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants