PHPLIB-1627: BulkWriteCommand API #1630
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Mar 4, 2025
GromNaN
reviewed
Mar 7, 2025
GromNaN
reviewed
Mar 17, 2025
jmikola
force-pushed
the
2.x-bulkwrite
branch
4 times, most recently
from
d9351cc to
33952f7
Compare
jmikola
force-pushed
the
2.x-bulkwrite
branch
3 times, most recently
from
f2cae41 to
c4c0deb
Compare
GromNaN
reviewed
Apr 4, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public function insertOne(array|object $document, mixed &$id = null): self | ||
| { | ||
| if ($this->codec) { | ||
| $document = $this->codec->encode($document); |
Check notice
Code scanning / Psalm
PossiblyInvalidArgument Note
There was a problem hiding this comment.
The type in DocumentCodec should be relaxed to @psalm-template ObjectType of object|array
| $filter = $this->builderEncoder->encodeIfSupported($filter); | ||
|
|
||
| if ($this->codec) { | ||
| $replacement = $this->codec->encode($replacement); |
Check notice
Code scanning / Psalm
PossiblyInvalidArgument Note
| */ | ||
| public function execute(Server $server): BulkWriteCommandResult | ||
| { | ||
| $inTransaction = isset($this->options['session']) && $this->options['session']->isInTransaction(); |
Check notice
Code scanning / Psalm
MixedMethodCall Note
|
|
||
| $options = array_filter($this->options, fn ($value) => isset($value)); | ||
|
|
||
| return $server->executeBulkWriteCommand($this->bulkWriteCommand, $options); |
Check notice
Code scanning / Psalm
MixedReturnStatement Note
GromNaN
reviewed
Apr 7, 2025
| public function insertOne(array|object $document, mixed &$id = null): self | ||
| { | ||
| if ($this->codec) { | ||
| $document = $this->codec->encode($document); |
There was a problem hiding this comment.
The type in DocumentCodec should be relaxed to @psalm-template ObjectType of object|array
The transaction spec requires certain language, and this is now expected in spec test for clientBulkWrite.
Also fixes the return type for getBuilderEncoder()
This is actually required for the union assignment in createWithCollection(). The nullable arrays were copied from the extension, but are inconsistent with other PHPLIB APIs.
Also renames the operation class to ClientBulkWriteCommand to avoid aliasing in Client.
GromNaN
reviewed
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1627
Requires mongodb/mongo-php-driver#1818