Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-283292. AtlasCustomRole CRDs #3450

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

CLOUDP-283292. AtlasCustomRole CRDs #3450

wants to merge 20 commits into from

Conversation

igor-karpukhin
Copy link
Contributor

Proposed changes

Jira ticket: CLOUDP-283292

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@igor-karpukhin igor-karpukhin force-pushed the CLOUDP-283292/custom-roles-crd branch from c0f68e6 to c694546 Compare December 20, 2024 20:38
@apix-bot APIx Bot
Copy link
Contributor

apix-bot bot commented Dec 26, 2024

Coverage Report 📈

Branch Commit Coverage
master c75db21 38.0%
CLOUDP-283292/custom-roles-crd 065ca22 38.9%
Difference .9%

@igor-karpukhin igor-karpukhin marked this pull request as ready for review December 27, 2024 17:45
@igor-karpukhin igor-karpukhin requested a review from a team as a code owner December 27, 2024 17:45
@igor-karpukhin igor-karpukhin requested a review from a team as a code owner December 27, 2024 17:45
helderjs
helderjs approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@helderjs helderjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helderjs helderjs helderjs approved these changes

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@josvazg josvazg Awaiting requested review from josvazg

@roothorp roothorp Awaiting requested review from roothorp

Assignees
No one assigned
Labels
atlascli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igor-karpukhin @helderjs