Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "CLOUDP-300869: Upgrade golangci to v1.64.5 (#3656)" #3667

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Revert "CLOUDP-300869: Upgrade golangci to v1.64.5 (#3656)" #3667

merged 1 commit into from
Feb 18, 2025

Conversation

blva
Copy link
Collaborator

@blva blva commented Feb 18, 2025

This reverts commit df33d20.

Proposed changes

Jira ticket: CLOUDP-#

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

andreaangiolillo
andreaangiolillo approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if LTEV 🌲

@fmenezes
Copy link
Collaborator

I wouldn't worry about code-coverage it is trying to use golang version from base commit, since we are downgrading it should work again after next commit

@blva blva marked this pull request as ready for review February 18, 2025 15:24
@blva blva requested a review from a team as a code owner February 18, 2025 15:24
@blva blva merged commit 5af7681 into master Feb 18, 2025
23 of 26 checks passed
@blva blva deleted the golangci-test branch February 18, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmenezes fmenezes fmenezes approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
atlascli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blva @fmenezes @andreaangiolillo