CLOUDP-315270: Generate SSDLC report with augmented SBOM on-demand #3916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cveticm
force-pushed
the
CLOUDP-315270_generate_augmented_sbom_and_report
branch
2 times, most recently
from
ea89146 to
923ebaa
Compare
cveticm
commented
May 28, 2025
| VERSION: ${{ inputs.release_version }} | ||
| AUGMENTED_SBOM_TEXT: " - See Augmented SBOM manifests (CycloneDX in JSON format): | ||
| \n - This file has been provided along with this report under the name 'linux_amd64_augmented_sbom_v${{ inputs.release_version }}.json' | ||
| \n - Please note that this file was generated on ${{ env.date }} and may not reflect the latest security information of all third party dependencies.\n" |
There was a problem hiding this comment.
Looking for reviewers' opinions on this:
I have the date the augmented SBOM is generated in the report as well as including the date in the file names of the report and augmented sbom.
Do you think this is sufficient to flag to the reader that this file can become out-of-date?
There was a problem hiding this comment.
I think so, but I'm OK with keeping this note.
blva
reviewed
May 29, 2025
| VERSION: ${{ inputs.release_version }} | ||
| AUGMENTED_SBOM_TEXT: " - See Augmented SBOM manifests (CycloneDX in JSON format): | ||
| \n - This file has been provided along with this report under the name 'linux_amd64_augmented_sbom_v${{ inputs.release_version }}.json' | ||
| \n - Please note that this file was generated on ${{ env.date }} and may not reflect the latest security information of all third party dependencies.\n" |
There was a problem hiding this comment.
I think so, but I'm OK with keeping this note.
cveticm
force-pushed
the
CLOUDP-315270_generate_augmented_sbom_and_report
branch
from
a2a1a60 to
958392e
Compare
andreaangiolillo
previously approved these changes
Jun 3, 2025
andreaangiolillo
approved these changes
Jun 3, 2025
Fixes sbom file name
cveticm
force-pushed
the
CLOUDP-315270_generate_augmented_sbom_and_report
branch
from
de5234a to
1030679
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Successful run of augment sbom action.
Verifying changes to report script and template do not effect update-ssdlc-report workflow.
Jira ticket: CLOUDP-315270
Checklist
make fmtand formatted my code