build: bump purego to build against newer go #3925
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
fmenezes
approved these changes
Jun 4, 2025
|
thanks for your contribution |
fmenezes
reviewed
Jun 4, 2025
| @@ -1,6 +1,6 @@ | |||
| module github.com/mongodb/mongodb-atlas-cli/atlascli | |||
|
|
|||
| go 1.24.2 | |||
| go 1.24.3 | |||
There was a problem hiding this comment.
Suggested change
| go 1.24.3 | |
| go 1.24.2 |
do you mind keeping it? our internal CI system does not support v1.24.3 yet.
There was a problem hiding this comment.
As soon as you change it, I'll rerun the tests
There was a problem hiding this comment.
also, we've recently updated unit tests on master, I'd apreciate if you could update your branch
|
I think #3930 has done all the changes you've proposed, feel free to reopen if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seeing build failure as below when building 1.43.0 release on homebrew side
relates to: