release instruction and script improvements #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-urbaniak
commented
Mar 21, 2024
| # set openshift versions | ||
| yq e -i '.annotations = .annotations + { "com.redhat.openshift.versions": "v4.8" }' \ | ||
| "${REPO}/${VERSION}"/metadata/annotations.yaml | ||
|
|
There was a problem hiding this comment.
Note: redhat-openshift-ecosystem/certified-operators#3619 was done using this script.
josvazg
reviewed
Mar 21, 2024
There was a problem hiding this comment.
These manual changes are still needed?
Eg:
Before posting the PR there is a manual change you need to make:
- Ensure to add the
quay.io/prefix in all Operator image references.
You can see an example fixed PR here on Community Operators for version 1.9.1.
I mean it has been fixed for certified, we could as well do it for the other 2.
josvazg
approved these changes
Mar 21, 2024
helderjs
approved these changes
Mar 21, 2024
|
@josvazg oh, you are right, that could be fixed in the scripts as well, let me do that actually 👍 |
helderjs
requested changes
Mar 25, 2024
helderjs
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).