-
Notifications
You must be signed in to change notification settings - Fork 9
Remove calculate_images_to_build function #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SimonBaeumer
wants to merge
5
commits into
master
Choose a base branch
from
simon/remove-unused-params
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejKaras
reviewed
May 16, 2025
8c1cb60
to
b333772
Compare
e69f976
to
3753163
Compare
MaciejKaras
approved these changes
Jun 13, 2025
nammn
approved these changes
Jun 16, 2025
Julien-Ben
requested changes
Jun 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the PR has been approved but all images builds are failing in CI
I'll block it to make sure we don't merge accidentally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing calculate_images_to_build function. This function was never used in the intended implementation.
exclude
was never used forpipeline.py
in CI & scirpts, onlyinclude
was used.--include
was only ever called once, it never usedaction=append
. To simplify the implementation just the key of the image to build is returned.Proof of Work
--exclude
and--include