MONGOID-5660: Remove deprecated monkey-patch methods (merge in Mongoid 10.x) #5745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
changed the title
|
All tickets in MONGOID-5660 were closed out and the epic was closed out. |
|
@alexbevi this PR is a follow-up to the epic, to remove the methods that Jamis marked as deprecated. It should be kept open and merged into Mongoid 10. Please raise a new ticket for this if needed... |
johnnyshields
changed the title
|
Ah I see, my mistake. |
…ecated-monkey-patch-methods
|
This is ready to merge when the team is ready to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated Monkey Patch methods.
@jamis it would be ideal to backport the deprecations to the 8.x branch so that we may remove the methods in 9.0. According to SemVer deprecations are allowed on minor releases (removals may only be done on major.)