test(NODE-6477): skip failing serverless tests (#4300)

mongodb · Oct 31, 2024 · 5e6638a · 5e6638a
1 parent 75a4f9a
commit 5e6638a
Show file tree

Hide file tree

Showing 8 changed files with 45 additions and 14 deletions.
diff --git a/.evergreen/run-serverless-tests.sh b/.evergreen/run-serverless-tests.sh
@@ -20,6 +20,7 @@ npx mocha \
   test/integration/sessions/sessions.prose.test.ts \
   test/integration/sessions/sessions.test.ts \
   test/integration/transactions/transactions.spec.test.ts \
+  test/integration/transactions-convenient-api/transactions-convenient-api.spec.test.ts \
   test/integration/transactions/transactions.test.ts \
   test/integration/versioned-api/versioned_api.spec.test.ts \
   test/integration/load-balancers/load_balancers.spec.test.ts \

diff --git a/test/integration/transactions-convenient-api/transactions-convenient-api.spec.test.ts b/test/integration/transactions-convenient-api/transactions-convenient-api.spec.test.ts
@@ -10,16 +10,6 @@ const SKIPPED_TESTS = [
 ];
 
 describe('Transactions Convenient API Spec Unified Tests', function () {
-  beforeEach(function () {
-    if (this.configuration.topologyType === 'LoadBalanced') {
-      if (this.currentTest) {
-        this.currentTest.skipReason =
-          'TODO(NODE-5931) - Fix socket leaks in load balancer transaction tests.';
-      }
-      this.skip();
-    }
-  });
-
   runUnifiedSuite(loadSpecTests(path.join('transactions-convenient-api', 'unified')), test => {
     return SKIPPED_TESTS.includes(test.description)
       ? 'TODO(NODE-5855): Skipping failing transaction tests'

diff --git a/test/spec/transactions-convenient-api/unified/commit-retry.json b/test/spec/transactions-convenient-api/unified/commit-retry.json
@@ -1,6 +1,6 @@
 {
   "description": "commit-retry",
-  "schemaVersion": "1.3",
+  "schemaVersion": "1.4",
   "runOnRequirements": [
     {
       "minServerVersion": "4.0",
@@ -422,6 +422,11 @@
     },
     {
       "description": "commit is not retried after MaxTimeMSExpired error",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "failPoint",

diff --git a/test/spec/transactions-convenient-api/unified/commit-retry.yml b/test/spec/transactions-convenient-api/unified/commit-retry.yml
@@ -1,6 +1,6 @@
 description: commit-retry
 
-schemaVersion: '1.3'
+schemaVersion: '1.4'
 
 runOnRequirements:
   - minServerVersion: '4.0'
@@ -212,6 +212,9 @@ tests:
           - { _id: 1 }
   -
     description: commit is not retried after MaxTimeMSExpired error
+    runOnRequirements:
+      # Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
+      - serverless: forbid
     operations:
       - name: failPoint
         object: testRunner

diff --git a/test/spec/transactions-convenient-api/unified/commit-writeconcernerror.json b/test/spec/transactions-convenient-api/unified/commit-writeconcernerror.json
@@ -1,6 +1,6 @@
 {
   "description": "commit-writeconcernerror",
-  "schemaVersion": "1.3",
+  "schemaVersion": "1.4",
   "runOnRequirements": [
     {
       "minServerVersion": "4.0",
@@ -414,6 +414,11 @@
     },
     {
       "description": "commitTransaction is not retried after UnknownReplWriteConcern error",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "failPoint",
@@ -546,6 +551,11 @@
     },
     {
       "description": "commitTransaction is not retried after UnsatisfiableWriteConcern error",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "failPoint",
@@ -678,6 +688,11 @@
     },
     {
       "description": "commitTransaction is not retried after MaxTimeMSExpired error",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "failPoint",

diff --git a/test/spec/transactions-convenient-api/unified/commit-writeconcernerror.yml b/test/spec/transactions-convenient-api/unified/commit-writeconcernerror.yml
@@ -1,6 +1,6 @@
 description: commit-writeconcernerror
 
-schemaVersion: '1.3'
+schemaVersion: '1.4' # For `serverless` in `runOnRequirements`
 
 runOnRequirements:
   - minServerVersion: '4.0'
@@ -151,6 +151,9 @@ tests:
     outcome: *outcome
   -
     description: commitTransaction is not retried after UnknownReplWriteConcern error
+    runOnRequirements:
+      # Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
+      - serverless: forbid
     operations:
       - name: failPoint
         object: testRunner
@@ -203,6 +206,9 @@ tests:
     outcome: *outcome
   -
     description: commitTransaction is not retried after UnsatisfiableWriteConcern error
+    runOnRequirements:
+      # Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
+      - serverless: forbid
     operations:
       - name: failPoint
         object: testRunner
@@ -226,6 +232,9 @@ tests:
     outcome: *outcome
   -
     description: commitTransaction is not retried after MaxTimeMSExpired error
+    runOnRequirements:
+      # Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
+      - serverless: forbid
     operations:
       - name: failPoint
         object: testRunner

diff --git a/test/spec/transactions/unified/retryable-commit.json b/test/spec/transactions/unified/retryable-commit.json
@@ -89,6 +89,11 @@
   "tests": [
     {
       "description": "commitTransaction fails after Interrupted",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "object": "testRunner",

diff --git a/test/spec/transactions/unified/retryable-commit.yml b/test/spec/transactions/unified/retryable-commit.yml
@@ -67,6 +67,9 @@ initialData:
 tests:
   -
     description: 'commitTransaction fails after Interrupted'
+    runOnRequirements:
+      # Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
+      - serverless: forbid
     operations:
       -
         object: testRunner