[WIP] refactor: define a then method instead of subclassing promise #4290
+18
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-6090
branch
2 times, most recently
from
808c6f3
to
03e42d4
Compare
An error occurred while trying to automatically change base from
NODE-6090
to
main
November 6, 2024 22:52
nbbeeken
force-pushed
the
chore-rm-subclass
branch
3 times, most recently
from
40a24ee
to
dbd359f
Compare
nbbeeken
force-pushed
the
chore-rm-subclass
branch
from
dbd359f
to
bad60d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Remove subclassing of promise. I deep dove into the motivations behind https://github.com/tc39/proposal-rm-builtin-subclassing yesterday. Perhaps we can accomplish the same convenience without the subclass. Leaving in draft, currently broken, a conversation for tech chat.
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript