Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6426): update prod dependencies #4327

Merged
merged 1 commit into from
Nov 21, 2024
Merged

chore(NODE-6426): update prod dependencies #4327

merged 1 commit into from
Nov 21, 2024

Conversation

durran
Copy link
Member

@durran durran commented Nov 13, 2024

Description

Updates prod dependencies

What is changing?

Updates the prod dependencies to latest semver compatible versions.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6426

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 13, 2024
@nbbeeken
Copy link
Contributor

https://spruce.mongodb.com/version/67363c9e3e0c430007cf6e5e/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Running a patch of main here to see if the performance issue repros without these changes

Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch passed, 😬 I think we need to take a closer look. What were the changes to saslprep?

@durran
Copy link
Member Author

durran commented Nov 15, 2024

The patch passed, 😬 I think we need to take a closer look. What were the changes to saslprep?

Was just a dev dependency bump in the package for the devtools mocha config. So nothing actually in production behaviour.

@nbbeeken nbbeeken merged commit a0431f0 into main Nov 21, 2024
29 checks passed
@nbbeeken nbbeeken deleted the NODE-6426-new branch November 21, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants