Skip to content

ci(NODE-6926): unskip failing FLE KMS test #4524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

ci(NODE-6926): unskip failing FLE KMS test #4524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions test/integration/client-side-encryption/client_side_encryption.prose.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
const invalidKmsProviders = getKmsProviders();
invalidKmsProviders.azure.identityPlatformEndpoint = 'doesnotexist.invalid:443';
invalidKmsProviders.gcp.endpoint = 'doesnotexist.invalid:443';
invalidKmsProviders.kmip.endpoint = 'doesnotexist.local:5698';
invalidKmsProviders.kmip.endpoint = 'doesnotexist.invalid:5698';

return this.client.connect().then(() => {
this.clientEncryption = new ClientEncryption(this.client, {
Expand Down Expand Up @@ -918,14 +918,9 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
succeed: true
},
{
description: '4. aws: custom endpoint with bad url',
provider: 'aws',
masterKey: {
region: 'us-east-1',
key: 'arn:aws:kms:us-east-1:579766882180:key/89fcc2c4-08b0-4bd9-9f25-e30687b580d0',
endpoint: 'kms.us-east-1.amazonaws.com:12345'
},
skipReason: 'TODO(NODE-6928): Fix failing aws bad URI test',
description: '4. bad url',
provider: 'kmip',
masterKey: { keyId: '1', endpoint: 'localhost:12345' },
succeed: false,
errorValidator: err => {
expect(err)
Expand Down Expand Up @@ -1029,7 +1024,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
provider: 'kmip',
masterKey: {
keyId: '1',
endpoint: 'doesnotexist.local:5698'
endpoint: 'doesnotexist.invalid:5698'
},
succeed: false,
errorValidator: err => {
Expand All @@ -1043,10 +1038,6 @@ describe('Client Side Encryption Prose Tests', metadata, function () {

testCases.forEach(testCase => {
it(testCase.description, metadata, function () {
if (testCase.skipReason) {
this.skipReason = testCase.skipReason;
this.skip();
}
// Call `client_encryption.createDataKey()` with <provider> as the provider and the following masterKey:
// .. code:: javascript
// {
Expand Down Expand Up @@ -1564,7 +1555,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
// Case 2.
context('Case 2: Azure', metadata, function () {
const masterKey = {
keyVaultEndpoint: 'doesnotexist.local',
keyVaultEndpoint: 'doesnotexist.invalid',
keyName: 'foo'
};

Expand Down Expand Up @@ -1834,7 +1825,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
// Call `client_encryption_with_names.createDataKey()` with "aws:no_client_cert" as the provider and the following masterKey.
const error = await clientEncryptionWithNames
.createDataKey('azure:no_client_cert', {
masterKey: { keyVaultEndpoint: 'doesnotexist.local', keyName: 'foo' }
masterKey: { keyVaultEndpoint: 'doesnotexist.invalid', keyName: 'foo' }
})
.catch(e => e);

Expand All @@ -1846,7 +1837,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
// Call `client_encryption_with_names.createDataKey()` with "aws:with_tls" as the provider and the same masterKey.
const error = await clientEncryptionWithNames
.createDataKey('azure:with_tls', {
masterKey: { keyVaultEndpoint: 'doesnotexist.local', keyName: 'foo' }
masterKey: { keyVaultEndpoint: 'doesnotexist.invalid', keyName: 'foo' }
})
.catch(e => e);

Expand Down
1 change: 0 additions & 1 deletion test/tools/runner/flaky.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ export const flakyTests = [
'Client Side Encryption Prose Tests 16. Rewrap Case 1: Rewrap with separate ClientEncryption should rewrap data key from local to kmip',
'Client Side Encryption Prose Tests 16. Rewrap Case 1: Rewrap with separate ClientEncryption should rewrap data key from local to local',
'Client Side Encryption Prose Tests 16. Rewrap Case 2: RewrapManyDataKeyOpts.provider is not optional when provider field is missing raises an error',
'Client Side Encryption Prose Tests Custom Endpoint Test 4. aws: custom endpoint with bad url',
'CSOT spec tests legacy timeouts behave correctly for retryable operations operation fails after two consecutive socket timeouts - aggregate on collection',
'CSOT spec tests legacy timeouts behave correctly for retryable operations operation succeeds after one socket timeout - aggregate on collection',
'CSOT spec tests operations ignore deprecated timeout options if timeoutMS is set socketTimeoutMS is ignored if timeoutMS is set - dropIndex on collection',
Expand Down