CLOUDP-283086: POC validator with custom function #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error output with new changes: |
gssbzn
reviewed
Nov 21, 2024
tools/ipa/Makefile
Outdated
| .PHONY: deps | ||
| deps: ## Download go module dependencies | ||
| @echo "==> Installing npx..." | ||
| npm install -g npx |
There was a problem hiding this comment.
if you gonan use npm can you move to a package json instead of a make file, also postman has a package json, let's please have a single package json and not multiple ones
There was a problem hiding this comment.
Yes, was copying the existing spectral makefile for now. Do you mean having the same package json for postman + ipa tool?
There was a problem hiding this comment.
Do you mean having the same package json for postman + ipa tool?
Yes a single source for dependencies in the repo, ie a mono repo approach
gssbzn
reviewed
Nov 21, 2024
| xgen-IPA-104-resource-has-GET: | ||
| description: "APIs must provide a get method for resources. http://go/ipa/104" | ||
| message: "{{error}} http://go/ipa/117" | ||
| severity: error |
gssbzn
reviewed
Nov 21, 2024
| @@ -0,0 +1,95 @@ | |||
| const ERROR_MESSAGE = "APIs must provide a get method for resources." | |||
|
|
|||
| export default (input, _, context) => { | |||
There was a problem hiding this comment.
can we document what version of ES can we use?
gssbzn
reviewed
Nov 21, 2024
Comment on lines
33
to
39
| function isChild(path) { | ||
| return path.endsWith("}") | ||
| } | ||
|
|
||
| function isCustomMethod(path) { | ||
| return path.includes(":") | ||
| } |
There was a problem hiding this comment.
Can these be defined in a separate file and imported here, I may answer one of @drinkbird questions
There was a problem hiding this comment.
Definitely, I expect we'll have a bunch of common helper functions we can import for different custom functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-#
Closes #[issue number]
Checklist
Changes to Spectral
Further comments