Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dop 3789 #853

Merged
merged 35 commits into from
Jul 17, 2023
Merged

Dop 3789 #853

merged 35 commits into from
Jul 17, 2023

Conversation

bianca-laube
Copy link
Contributor

Stories/Links:

DOP-3789

Current Behavior:

https://www.mongodb.com/docs/search/?q=shell
Screenshot 2023-07-12 at 1 06 22 PM

Staging Links:

https://docs-mongodb-org-stg.s3.us-east-2.amazonaws.com/master/landing/bianca.laube/DOP-3789/search/index.html?q=shell
Screenshot 2023-07-12 at 1 08 46 PM

Notes:

Changes:

  • new white background to differ from side bar
  • more rounded corners on search result container
  • hover state now doesn't blur out the other search results, instead adds a darker drop shadow
  • new blue title for search result
  • new link state: now if you have selected a previous search result in the history the search result title will be purple (instead of nothing happening)
  • new highlight of search result word: it is now a light green instead of yellow with rounded corners. Also, got rid of highlighting words in the title
  • in mobile version the title shouldn't be disappearing now

when testing:

Copy link
Collaborator

@branberry branberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bianca! This looks good to me, just one small nit

src/components/SearchResults/SearchResult.js Outdated Show resolved Hide resolved
@bianca-laube bianca-laube requested a review from mmeigs July 14, 2023 18:03
@bianca-laube bianca-laube requested a review from mmeigs July 17, 2023 17:07
Copy link
Collaborator

@branberry branberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bianca-laube bianca-laube merged commit 9c2502a into master Jul 17, 2023
2 checks passed
@bianca-laube bianca-laube deleted the DOP-3789 branch July 17, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants