Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dop 3786: updating no search results modal #854

Merged
merged 44 commits into from
Jul 18, 2023
Merged

Dop 3786: updating no search results modal #854

merged 44 commits into from
Jul 18, 2023

Conversation

bianca-laube
Copy link
Contributor

Stories/Links:

DOP-3786

Current Behavior:

https://www.mongodb.com/docs/search/?q=%22failed%20to%20find%20a%20plan%22*
Screenshot 2023-07-13 at 4 10 23 PM

Staging Links:

https://docs-mongodb-org-stg.s3.us-east-2.amazonaws.com/master/landing/bianca.laube/DOP-3786/search/index.html?q=%22failed%20to%20find%20a%20plan%22*
Screenshot 2023-07-13 at 4 12 01 PM

Notes:

Changes

The four different states for empty/no results search (and what to look for when testing)
confirmed by Iz

  1. Empty search input from the top nav search bar

  2. Empty search input from persistent search bar

    • if after they input something from the top nav search and they delete it in the persistent search bar and then hit enter, it should show the no results module and not null

Screenshot 2023-07-13 at 4 21 48 PM
3. Non-empty search input but no search results
- should show no results module
Screenshot 2023-07-13 at 4 12 01 PM
4. Non-empty search input but when filter selected, no results
- should show no results module
Screenshot 2023-07-13 at 4 18 15 PM

  • everything else should work correctly as before
  • when feature flag is false, prod should work the exact same as before

Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing a pending loading screen when entering /search page https://docs-mongodb-org-stg.s3.us-east-2.amazonaws.com/master/landing/bianca.laube/DOP-3786/search/index.html

seems to be stemming from searchResults changes atm

src/components/SearchResults/SearchResults.js Outdated Show resolved Hide resolved
Base automatically changed from DOP-3789 to master July 17, 2023 17:52
@seungpark
Copy link
Collaborator

what is the expected behavior when landing on search page? from figma, i am seeing just the title and the search bar:
image

but on branch, i am seeing the filters and the result count:
image

if this is out of scope, please link the ticket that will address this issue.
also for case 2, (user deletes input and hit enter) should this result in a "no search results"? google search does not allow for empty input, and results in nothing happening on UI end if no input

Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM. thanks for cleaning it up!

@bianca-laube bianca-laube merged commit 38e2621 into master Jul 18, 2023
2 checks passed
@bianca-laube bianca-laube deleted the DOP-3786 branch July 18, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants