DRIVERS-2830 - FaaS detection logic mistakenly identifies EKS as AWS Lambda #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Oct 9, 2024
| @@ -327,6 +327,8 @@ Depending on which `client.env.name` has been selected, other FaaS fields in `cl | |||
| Missing variables or variables with values not matching the expected type MUST cause the corresponding `client.env` | |||
| field to be omitted and MUST NOT cause a user-visible error. | |||
|
|
|||
| If any fields of `client.env.container` are populated, all FaaS values MUST be entirely omitted. | |||
There was a problem hiding this comment.
What about cases where a container is deployed on AWS Lambda? https://docs.aws.amazon.com/lambda/latest/dg/images-create.html
Wouldn't we want to include both in that case?
IIRC the issue that motivated this drivers ticket was a customer was not using Lambda but lambda still showed up in the client metadata. It looks like they were using pymongo 4.6.0. We added container detection in pymongo 4.7: PYTHON-3837.
blink1073
reviewed
Oct 11, 2024
| @@ -511,6 +511,16 @@ the following sets of environment variables: | |||
| | -------------------- | ----- | | |||
| | `AWS_EXECUTION_ENV` | `EC2` | | |||
|
|
|||
| 9. Valid container and FaaS provider. This test MUST verify that both the container metadata and the AWS Lambda metadata | |||
There was a problem hiding this comment.
We should include a note about this behavior in the client.env description above as well.
|
Perhaps update that link to https://en.wikipedia.org/wiki/Balls_into_bins_problem? |
ShaneHarvey
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRIVERS-2830 Summary of changes:
Python implementation: mongodb/mongo-python-driver#1908.