-
Notifications
You must be signed in to change notification settings - Fork 246
DRIVERS-2782: Expose snapshotTime #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
atClusterTime: | ||
"$$exists": true | ||
|
||
## This test seems to be wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO create ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's create the ticket and remove this comment as non-informative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
atClusterTime: | ||
"$$exists": true | ||
|
||
## This test seems to be wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's create the ticket and remove this comment as non-informative.
|
||
## Specific operations and behaviour for unified tests | ||
|
||
An operation on sessions called `getSnapshotTime` must be supported for unified tests. This operation returns the value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for returning with this again, but I've just realized that we should mirror this changes into unified test format spec:
here: https://github.com/mongodb/specifications/blob/master/source/unified-test-format/unified-test-format.md#session-operations
and here: https://github.com/mongodb/specifications/blob/master/source/unified-test-format/unified-test-format.md#entity_session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've mirrored this in the Session Operations section in unified test format spec. I did not modify the Entity Session section, as it already refers to the single spec documents, where I've already added the necessary info.
C# driver implementation POC: mongodb/mongo-csharp-driver#1777
TODO:
clusters).
getSnapshotTime
operation (for unified tests).snapshotTime
parameter ofsessionOptions
and that it must be retrieved from the entity map (for unified tests).