Skip to content

Conversation

papafe
Copy link

@papafe papafe commented Sep 23, 2025

C# driver implementation POC: mongodb/mongo-csharp-driver#1777

TODO:

  • Update changelog.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters).
  • Add unified tests.
  • Add prose test for validation of input.
  • Add information about the new getSnapshotTime operation (for unified tests).
  • Add information about the new snapshotTime parameter of sessionOptions and that it must be retrieved from the entity map (for unified tests).
  • Check that re-doing the query operation is best course of action for unified tests to verify that the snapshotTime does not get modified again.

atClusterTime:
"$$exists": true

## This test seems to be wrong
Copy link
Author

@papafe papafe Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO create ticket

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create the ticket and remove this comment as non-informative.

@papafe papafe marked this pull request as ready for review September 29, 2025 15:17
@papafe papafe requested a review from a team as a code owner September 29, 2025 15:17
@papafe papafe requested review from sanych-sun and removed request for a team September 29, 2025 15:17
@papafe papafe changed the title [WIP] DRIVERS-2782 Expose snapshotTime DRIVERS-2782: Expose snapshotTime Sep 29, 2025
@sanych-sun sanych-sun requested a review from qingyang-hu October 2, 2025 18:21
@papafe papafe requested a review from sanych-sun October 3, 2025 08:49
Copy link
Contributor

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

atClusterTime:
"$$exists": true

## This test seems to be wrong
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create the ticket and remove this comment as non-informative.


## Specific operations and behaviour for unified tests

An operation on sessions called `getSnapshotTime` must be supported for unified tests. This operation returns the value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mirrored this in the Session Operations section in unified test format spec. I did not modify the Entity Session section, as it already refers to the single spec documents, where I've already added the necessary info.

@papafe papafe requested a review from a team as a code owner October 15, 2025 18:22
@papafe papafe requested review from alcaeus and sanych-sun and removed request for a team October 15, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants