minor

mongodb · Oct 11, 2024 · 346915a · 346915a
1 parent c904b4f
commit 346915a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/tools/codegen/codespec/api_to_provider_spec_mapper.go b/tools/codegen/codespec/api_to_provider_spec_mapper.go
@@ -82,6 +82,7 @@ func pathParamsToAttributes(createOp, readOp *high.Operation) Attributes {
 		}
 
 		paramName := param.Name
+		s.Schema.Description = param.Description
 		parameterAttribute, err := s.buildResourceAttr(paramName, ComputedOptional)
 		if err != nil {
 			log.Printf("[WARN] Path param %s could not be mapped: %s", paramName, err)

diff --git a/tools/codegen/codespec/api_to_provider_spec_mapper_test.go b/tools/codegen/codespec/api_to_provider_spec_mapper_test.go
@@ -12,7 +12,7 @@ import (
 const (
 	testFieldDesc     = "Test field description"
 	testResourceDesc  = "Configures the project level settings for the Test Resource feature."
-	testPathParamDesc = "GroupId path param test description"
+	testPathParamDesc = "Path param test description"
 )
 
 type convertToSpecTestCase struct {
@@ -55,7 +55,7 @@ func TestConvertToProviderSpec(t *testing.T) {
 								Name:                     "group_id",
 								ComputedOptionalRequired: codespec.Required,
 								String:                   &codespec.StringAttribute{},
-								// Description: &testPathParamDesc,
+								Description:              conversion.StringPtr(testPathParamDesc),
 							},
 							codespec.Attribute{
 								Name:                     "num_double_default_attr",

diff --git a/tools/codegen/codespec/terraform_helper.go b/tools/codegen/codespec/terraform_helper.go
@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"regexp"
 	"strings"
-	"unicode/utf8"
 )
 
 var (
@@ -20,12 +19,10 @@ func terraformAttrName(attrName string) string {
 	removedUnsupported := unsupportedCharacters.ReplaceAllString(attrName, "")
 
 	insertedUnderscores := camelCase.ReplaceAllStringFunc(removedUnsupported, func(s string) string {
-		firstRune, size := utf8.DecodeRuneInString(s)
-		if firstRune == utf8.RuneError && size <= 1 {
-			return s
-		}
-
-		return fmt.Sprintf("%s_%s", string(firstRune), strings.ToLower(s[size:]))
+		firstChar := s[0]
+		restOfString := s[1:]
+		return fmt.Sprintf("%c_%s", firstChar, strings.ToLower(restOfString))
 	})
+
 	return strings.ToLower(insertedUnderscores)
 }
diff --git a/tools/codegen/codespec/testdata/api-spec.yml b/tools/codegen/codespec/testdata/api-spec.yml
@@ -122,7 +122,7 @@ components:
   parameters:
     groupId:
       description: >-
-        GroupId path param test description
+        Path param test description
       in: path
       name: groupId
       required: true