extract common vars in migration tests

mongodb · Nov 30, 2023 · 5ef33e4 · 5ef33e4
1 parent 0d04062
commit 5ef33e4
Showing 1 changed file with 4 additions and 22 deletions.
diff --git a/.github/workflows/migration-tests.yml b/.github/workflows/migration-tests.yml
@@ -13,6 +13,10 @@ on:
     - cron: "0 4 * * *" # workflow runs every day at 04:00 AM  
 env:
     terraform_version: ${{ inputs.terraform_version || vars.TF_VERSION_LATEST }}
+    # CI: true  # GH does this automatically
+    TF_ACC: 1
+    TF_LOG: ERROR
+    SKIP_TEST_EXTERNAL_CREDENTIALS: true
 jobs: 
   change-detection:
     runs-on: ubuntu-latest
@@ -75,12 +79,6 @@ jobs:
           MONGODB_ATLAS_BASE_URL: ${{ vars.MONGODB_ATLAS_BASE_URL }}
           MONGODB_ATLAS_PROJECT_OWNER_ID: ${{ vars.MONGODB_ATLAS_PROJECT_OWNER_ID }}
           MONGODB_ATLAS_TEAMS_IDS: ${{ vars.MONGODB_ATLAS_TEAMS_IDS }}
-          SKIP_TEST_EXTERNAL_CREDENTIALS: ${{ vars.SKIP_TEST_EXTERNAL_CREDENTIALS }}
-          ACCTEST_TIMEOUT: ${{ vars.ACCTEST_TIMEOUT }}
-          TF_LOG: ${{ vars.LOG_LEVEL }}
-          TF_ACC: 1
-          PARALLEL_GO_TEST: 20
-          CI: true
           TEST_REGEX: "^TestAccMigrationProject"
         run: make testacc
 
@@ -113,16 +111,10 @@ jobs:
           MONGODB_ATLAS_ORG_ID: ${{ vars.MONGODB_ATLAS_ORG_ID_CLOUD_DEV_NETWORK }}
           MONGODB_ATLAS_BASE_URL: ${{ vars.MONGODB_ATLAS_BASE_URL }}
           MONGODB_ATLAS_PROJECT_OWNER_ID: ${{ vars.MONGODB_ATLAS_PROJECT_OWNER_ID }}
-          SKIP_TEST_EXTERNAL_CREDENTIALS: ${{ vars.SKIP_TEST_EXTERNAL_CREDENTIALS }}
           MONGODB_ATLAS_USERNAME_CLOUD_DEV: ${{ vars.MONGODB_ATLAS_USERNAME_CLOUD_DEV }}
           AZURE_ATLAS_APP_ID: ${{vars.AZURE_ATLAS_APP_ID}}
           AZURE_SERVICE_PRINCIPAL_ID: ${{vars.AZURE_SERVICE_PRINCIPAL_ID}}
           AZURE_TENANT_ID: ${{vars.AZURE_TENANT_ID}}
-          ACCTEST_TIMEOUT: ${{ vars.ACCTEST_TIMEOUT }}
-          TF_LOG: ${{ vars.LOG_LEVEL }}
-          TF_ACC: 1
-          PARALLEL_GO_TEST: 20
-          CI: true
           TEST_REGEX: "^TestAccMigrationConfig"
         run: make testacc
 
@@ -155,11 +147,6 @@ jobs:
           MONGODB_ATLAS_ORG_ID: ${{ vars.MONGODB_ATLAS_ORG_ID_CLOUD_DEV }}
           MONGODB_ATLAS_BASE_URL: ${{ vars.MONGODB_ATLAS_BASE_URL }}
           MONGODB_ATLAS_PROJECT_OWNER_ID: ${{ vars.MONGODB_ATLAS_PROJECT_OWNER_ID }}
-          SKIP_TEST_EXTERNAL_CREDENTIALS: ${{ vars.SKIP_TEST_EXTERNAL_CREDENTIALS }}
-          ACCTEST_TIMEOUT: ${{ vars.ACCTEST_TIMEOUT }}
-          TF_LOG: ${{ vars.LOG_LEVEL }}
-          TF_ACC: 1
-          PARALLEL_GO_TEST: 20
           TEST_REGEX: "^TestAccMigrationBackup"
         run: make testacc
 
@@ -191,10 +178,5 @@ jobs:
           MONGODB_ATLAS_PRIVATE_KEY: ${{ secrets.MONGODB_ATLAS_PRIVATE_KEY_CLOUD_DEV }}
           MONGODB_ATLAS_ORG_ID: ${{ vars.MONGODB_ATLAS_ORG_ID_CLOUD_DEV }}
           MONGODB_ATLAS_BASE_URL: ${{ vars.MONGODB_ATLAS_BASE_URL }}
-          SKIP_TEST_EXTERNAL_CREDENTIALS: ${{ vars.SKIP_TEST_EXTERNAL_CREDENTIALS }}
-          ACCTEST_TIMEOUT: ${{ vars.ACCTEST_TIMEOUT }}
-          TF_LOG: ${{ vars.LOG_LEVEL }}
-          TF_ACC: 1
-          PARALLEL_GO_TEST: 20
           TEST_REGEX: "^TestAccMigrationAdvancedCluster"
         run: make testacc