Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updates mongodbatlas_federated_settings_org_config with data_access_identity_provider_ids, user_conflicts, and changes to identity_provider_id #2322

Merged
merged 18 commits into from
Jun 5, 2024

Conversation

EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented Jun 3, 2024

Description

changelog changes:

  • feat(rs/ds): Adds data_access_identity_provider_ids
  • feat(rs): Adds user_conflicts
  • feat(rs): Supports detaching and updating the identity_provider_id

minor changes:

  • reuse user_conflicts elem schema across resource/data_sources
  • shorten method names
  • fix error messages when reading dataSource(s)
  • add test coverage for updates

Link to any related issue(s): CLOUDP-250916

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Tests run

go test -timeout 2400s -run ^(TestAccFederatedSettingsOrg_createError|TestAccFederatedSettingsOrg_basic)$ github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgconfig -v

=== RUN   TestAccFederatedSettingsOrg_createError
=== PAUSE TestAccFederatedSettingsOrg_createError
=== RUN   TestAccFederatedSettingsOrg_basic
=== PAUSE TestAccFederatedSettingsOrg_basic
=== CONT  TestAccFederatedSettingsOrg_createError
=== CONT  TestAccFederatedSettingsOrg_basic
--- PASS: TestAccFederatedSettingsOrg_createError (2.83s)
--- PASS: TestAccFederatedSettingsOrg_basic (18.47s)
PASS
ok      github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgconfig

@EspenAlbert EspenAlbert changed the title feat: Updates mongodbatlas_federated_settings_org_config with data_access_identity_provider_ids feat: Updates mongodbatlas_federated_settings_org_config with data_access_identity_provider_ids, user_conflicts, and updates to identity_provider_id Jun 4, 2024
@EspenAlbert EspenAlbert changed the title feat: Updates mongodbatlas_federated_settings_org_config with data_access_identity_provider_ids, user_conflicts, and updates to identity_provider_id feat: Updates mongodbatlas_federated_settings_org_config with data_access_identity_provider_ids, user_conflicts, and changes to identity_provider_id Jun 4, 2024
- feat(rs/ds): Adds `data_access_identity_provider_ids`
- feat(rs): Adds `user_conflicts`
- feat(rs): Supports detaching and updating the `identity_provider_id`
@EspenAlbert EspenAlbert marked this pull request as ready for review June 4, 2024 10:33
@EspenAlbert EspenAlbert requested review from a team as code owners June 4, 2024 10:33
Copy link
Contributor

github-actions bot commented Jun 4, 2024

APIx bot: a message has been sent to Docs Slack channel

Copy link
Collaborator

@jwilliams-mongo jwilliams-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@jwilliams-mongo jwilliams-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EspenAlbert lgtm!

@EspenAlbert EspenAlbert merged commit 87ef9c0 into master Jun 5, 2024
33 of 34 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-250916_org_config_workload_oidc_idp branch June 5, 2024 14:20
@EspenAlbert
Copy link
Collaborator Author

Merged. OUT_OF_CAPACITY error was the failing test

svc-apix-Bot added a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants