Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Supports new networking attribute in mongodbatlas_stream_connection #2474

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Aug 2, 2024

Description

Supports new networking attribute in mongodbatlas_stream_connection
This attribute is only used when type of connection is Kafka.
Attribute is Computed and Optional. This is because it can be set by the user but it also has a default value if is not set by the user and is always returned by the API.

Link to any related issue(s): CLOUDP-265074

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi marked this pull request as ready for review August 2, 2024 09:11
@oarbusi oarbusi requested review from a team as code owners August 2, 2024 09:11
Copy link
Contributor

github-actions bot commented Aug 2, 2024

APIx bot: a message has been sent to Docs Slack channel

Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving suggestions but in general LGTM

.changelog/2474.txt Outdated Show resolved Hide resolved
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@corryroot corryroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oarbusi
Copy link
Collaborator Author

oarbusi commented Aug 8, 2024

Waiting to merge this until stream_connection is not created by default when creating a stream_instance

Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Aug 15, 2024
@oarbusi oarbusi removed the stale label Aug 16, 2024
@@ -65,6 +66,10 @@ func testCaseKafkaPlaintext(t *testing.T) *resource.TestCase {
},
}
}
func DummySleep(*terraform.State) error {
Copy link
Collaborator

@EspenAlbert EspenAlbert Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge blocker: Getting 500s when a stream connection changes networking to VPC and is deleted straight afterwards. Detailed Jira Ticket

@EspenAlbert
Copy link
Collaborator

EspenAlbert commented Aug 20, 2024

Merge blocked by upstream breaking change, wait for this and remove access.name attribute

Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Aug 26, 2024
@oarbusi oarbusi removed the stale label Aug 26, 2024
@EspenAlbert EspenAlbert added the not_stale Not stale issue or PR label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement not_stale Not stale issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants