-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removes deprecation warnings for labels
in cluster/adv_cluster
#2678
base: master
Are you sure you want to change the base?
Conversation
APIx bot: a message has been sent to Docs Slack channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small doubt
@@ -124,8 +124,6 @@ To learn more, see [Resource Tags](https://dochub.mongodb.org/core/add-cluster-t | |||
|
|||
### labels | |||
|
|||
**WARNING:** This property is deprecated and will be removed in the future, use the `tags` attribute instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add changelog entries under NOTES section to clarify this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. WDYT @Zuhairahmed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no i would rather not add anything to changelog here. reason is because in a few months we will be adding this deprecation warning back once upstream team has finalized a new EOL date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Removes deprecation warnings for
labels
in cluster/adv_clusterLink to any related issue(s): CLOUDP-273888
Type of change:
Required Checklist:
Further comments