Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add typescript types #37

Merged
merged 3 commits into from
Mar 4, 2024
Merged

add typescript types #37

merged 3 commits into from
Mar 4, 2024

Conversation

vkarpov15
Copy link
Member

No description provided.

@vkarpov15 vkarpov15 mentioned this pull request Mar 1, 2024
Merged
hasezoey
hasezoey reviewed Mar 2, 2024
View reviewed changes
Copy link
Member

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good initially, maybe consider adding some comments explaining some of the less obvious types / parameters, like unshift, args or functions

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@vkarpov15 vkarpov15 requested a review from hasezoey March 4, 2024 17:40
hasezoey
hasezoey approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now, it would be even better if there would be some tsdoc (as there already exists jsdoc), but i guess this could wait.
also, please know that i am not that familiar with kareem's api or internals.

@vkarpov15 vkarpov15 merged commit 4e5624d into master Mar 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkarpov15 @hasezoey