-
Notifications
You must be signed in to change notification settings - Fork 141
Gtk sharp 2 msi improvements #115
base: gtk-sharp-2-12-branch
Are you sure you want to change the base?
Gtk sharp 2 msi improvements #115
Conversation
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
2 similar comments
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
approve |
This looks good to me, as long as the installer works, we should update the binary to be compatible with the latest mono release. Want confirmation from @bratsche that it's good to merge. |
…tion Mono.Posix.dll is a binary dependency that is shipped with the msi installer. To streamline msi installer generation Mono.Posix.dll and its helper library MonoPosixHelper.dll have been included in the repository and the msi installer definition has been updated accordingly. In order to fix XamBug #3843, I've added not only the .NET 2 version of Mono.Posix.dll but also the .Net 4 version.
Previously Mono.Cairo has been merged into the installer via a .msm file. Since Mono.Cairo is built as part of this package, it's only natural to include it directly in the msi installer definition.
Although newer mono releases exist, 3.12.1 was the last release with properly strong named Mono.Posix DLLs. Since the msi installer installs those DLLs into the GAC they need to be strong named.
I've updated the binaries. There was a small problem though: Mono releases since 4.0 don't include fully signed Mono.Posix DLLs. The last release with fully signed DLLs was 3.12.1. So I took the binaries from that release. |
Hi! It looks like this fixes a rather old issue from 2012 [1]. I stumbled into this by doing some some testing with Visual Studio for Mac and Gtk# when attempting to run my Application on Windows. (After installing the Latest Gtk# Runtime from [2]). The current stable Gtk# Installer for Windows still just installs Mono.Posix 2.0.0, but any new Gtk# Project created with Visual Studio for Mac (and presumably MonoDevelop) references Mono.Posix 4.0.0. As a result the .exe will not launch on Windows. Are there any plans to merge this and release an updated Installer for Windows in the near future? In the meantime, the way to "fix" this seems to be this NuGet Package [3]. But IMHO it would be much nicer if the Gtk# Installer is updated accordingly. ;) Thanks, [1] https://bugzilla.xamarin.com/show_bug.cgi?id=3843 |
And please remove Build() from constructure. I want write own because it is clean than Build() because MonoDevelop or Visual Studio 2017 Community don't know for GTK 2 with hidden C# Generate.cs.- Please make sure without Build(); I like GTK2 for Linux with OpenTK 2.0 / 3.0 pre. Please explain me! I want release applications ( alternative Sledge Hammer ) for Half-Life under Linux and FreeBSD. And how does it work for MenuBar if I click New -> New map than it shows menus like advanced "menu items" like WPF or WinForms has not problem with if-else statements "!MyEditMenu...." just if it doesn't exist than menu will add. or if-else statement with "MyEditMenu...." exists than it will remove Is it sure supporting for GTK 2 too? Thanks! |
This is a PR for the gtk-sharp-2-12-branch.
This PR aims to streamline the msi installer generation process by including the binaries for Mono.Posix.dll (taken from mono 3.2.3 win32 release) and pulling Mono.Cairo directly from this repository (instead of using a manually imported .msm file).