Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISSUE #706 The color of CMYK pixel format pictures is incorrect. #707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

e8-ShiWei
Copy link

Values of b and r are incorrect.
Red is assigned to b, and blue is assigned to r.

Swap the positions of b and r.
Fix to:

r = (255 - k) * (255 - c) / 255;
g = (255 - k) * (255 - m) / 255;
b = (255 - k) * (255 - y) / 255;

Example, red:
C = 0%
M = 100%
Y = 100%
K = 0%

=>

R = 255 * 255 / 255 = 255
G = 255 * 0 / 255 = 0
B = 255 * 0 / 255 = 0

@e8-ShiWei
Copy link
Author

Hi, any update? When will we get a release version containing this modification?
If it takes a long time to release a new version, we may need to compile this library ourselves.
Thanks.

@filipnavara
Copy link
Contributor

Usually the release cadence of this library is quite slow. @akoeplinger, can you look at this PR / approve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants