This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Fix for TypeExtensionPoint in generic classes #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows to have generic classes for plugins. For instance, the following interface will be the
TypeExtensionPoint
:Then, we could have plugins implementing this class like:
The problem was that the
path
variable contains the list of type names that the class implements. The types are separated by commas. In the case of generics, the type name contains also the list of types of the typeparam. for instance in this example,path
contains:So if we just split by commas, we would get mix information with the generic types. Using the new approach we skip the information of the generic enclosed by
[ ]
so we get: