This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 241
Simplify implementation for ImageTagSet equality #1116
Draft
Therzok
wants to merge
11
commits into
main
Choose a base branch
from
dev/therzok/image-optimization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3550ded
Simplify implementation for ImageTagSet equality
Therzok 25cb1aa
Reuse the same tag separator array
Therzok 30ee113
Add a lookup table for most common tags used in images
Therzok 1557d48
Remove unused tags string and improvements to caching
Therzok 455d72b
Forgot to initialize
Therzok 3dd2e28
Correct formatting of tags string
Therzok cb9c628
Avoid allocating substrings
Therzok 7511a91
Reuse a cached array for the manifest resource names
Therzok 681e4cd
More caching in enumerating alternative files
Therzok be8d81a
Use specialized APIs to get the handles
Therzok b4ceca4
This shoudl be static
Therzok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check breaks my brain. I don't really understand why it is
!Context.RegisteredStyles.Any()