Skip to content

Commit

Permalink
Merge pull request #19 from monsieurbiz/fix/product-option-trait-cons…
Browse files Browse the repository at this point in the history
…tructor

fix(ProductOptionValue): Fix ProductOptionValue trait constructor override
  • Loading branch information
maximehuran authored Sep 4, 2024
2 parents 41cf5e9 + b0b3762 commit 306a18a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ Copy the templates we override:
cp -Rv vendor/monsieurbiz/sylius-advanced-option-plugin/src/Resources/templates/* templates/
```

Your ProductOption entity needs to implement the `RenderedOptionInterface` interface and use the `MonsieurBiz\SyliusAdvancedOptionPlugin\Entity\ProductOption\RenderedOptionTrait` trait. As in our test application: [ProductOption](tests/Application/src/Entity/Product/ProductOption.php).
Your ProductOption entity needs to implement the `RenderedOptionInterface` interface and use the `MonsieurBiz\SyliusAdvancedOptionPlugin\Entity\ProductOption\RenderedOptionTrait` trait. As in our test application: [ProductOption](dist/src/Entity/Product/ProductOption.php).

Your ProductOptionValue entity needs to implement the `RenderedOptionValueInterface` interface and use the `MonsieurBiz\SyliusAdvancedOptionPlugin\Entity\ProductOption\RenderedOptionValueTrait` trait. As in our test application: [ProductOption](tests/Application/src/Entity/Product/ProductOptionValue.php).
Your ProductOptionValue entity needs to implement the `RenderedOptionValueInterface` interface and use the `MonsieurBiz\SyliusAdvancedOptionPlugin\Entity\ProductOption\RenderedOptionValueTrait` trait. As in our test application: [ProductOption](dist/src/Entity/Product/ProductOptionValue.php).

### Migrations

Expand Down
2 changes: 1 addition & 1 deletion dist/src/Entity/Product/ProductOptionValue.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
class ProductOptionValue extends BaseProductOptionValue implements RenderedOptionValueInterface
{
use RenderedOptionValueTrait {
__construct as private initializeImagesCollection;
RenderedOptionValueTrait::__construct as private initializeImagesCollection;
}

public function __construct()
Expand Down

0 comments on commit 306a18a

Please sign in to comment.