fix: Add missing Migration #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesbh
added
Priority: high
jacquesbh
force-pushed
the
missing-migration
branch
from
83b5402 to
e1dd67c
Compare
delyriand
requested changes
Nov 16, 2023
| public function down(Schema $schema): void | ||
| { | ||
| // this down() migration is auto-generated, please modify it to your needs | ||
| $this->addSql('ALTER TABLE monsieurbiz_shipping_slot_config CHANGE rrules rrules JSON DEFAULT NULL'); |
There was a problem hiding this comment.
🎯 suggestion: I think it depends on the version of doctrine and mysql, we could do like Sylius: https://github.com/Sylius/Sylius/blob/336682edb5be6e2885bde0179816891315d89777/src/Sylius/Bundle/CoreBundle/Migrations/Version20211018130725.php
Suggested change
| $this->addSql('ALTER TABLE monsieurbiz_shipping_slot_config CHANGE rrules rrules JSON DEFAULT NULL'); | |
| $this->addSql('ALTER TABLE monsieurbiz_shipping_slot_config CHANGE rrules rrules LONGTEXT DEFAULT NULL'); |
There was a problem hiding this comment.
@jacquesbh I did it in the PR #21
madamebiz
added
Status: needs update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel strange about this change which is not a change 😅…
This is shit, but how did you fix it guys? 🤣