fix: 5691 - fallback when "nulls last" not supported by db

monsieurtanuki · Oct 12, 2024 · d76e37e · d76e37e
1 parent 449ae5a
commit d76e37e
Showing 1 changed file with 36 additions and 17 deletions.
diff --git a/packages/smooth_app/lib/database/dao_product.dart b/packages/smooth_app/lib/database/dao_product.dart
@@ -278,23 +278,42 @@ class DaoProduct extends AbstractSqlDao implements BulkDeletable {
     required final int limit,
     required final List<String> excludeBarcodes,
   }) async {
-    final List<Map<String, dynamic>> queryResults =
-        await localDatabase.database.rawQuery(
-      'select p.$_TABLE_PRODUCT_COLUMN_BARCODE '
-      'from'
-      ' $_TABLE_PRODUCT p'
-      ' left outer join ${DaoProductLastAccess.TABLE} a'
-      '  on p.$_TABLE_PRODUCT_COLUMN_BARCODE = a.${DaoProductLastAccess.COLUMN_BARCODE} '
-      'where'
-      ' p.$_TABLE_PRODUCT_COLUMN_LANGUAGE is null'
-      ' or p.$_TABLE_PRODUCT_COLUMN_LANGUAGE != ? '
-      'order by a.${DaoProductLastAccess.COLUMN_LAST_ACCESS} desc nulls last '
-      'limit ?',
-      <Object>[
-        language.offTag,
-        limit + excludeBarcodes.length,
-      ],
-    );
+    /// Unfortunately, some SQFlite implementations don't support "nulls last"
+    String getRawQuery(final bool withNullsLast) =>
+        'select p.$_TABLE_PRODUCT_COLUMN_BARCODE '
+        'from'
+        ' $_TABLE_PRODUCT p'
+        ' left outer join ${DaoProductLastAccess.TABLE} a'
+        '  on p.$_TABLE_PRODUCT_COLUMN_BARCODE = a.${DaoProductLastAccess.COLUMN_BARCODE} '
+        'where'
+        ' p.$_TABLE_PRODUCT_COLUMN_LANGUAGE is null'
+        ' or p.$_TABLE_PRODUCT_COLUMN_LANGUAGE != ? '
+        'order by a.${DaoProductLastAccess.COLUMN_LAST_ACCESS} desc ${withNullsLast ? 'nulls last' : ''} '
+        'limit ?';
+
+    List<Map<String, dynamic>> queryResults = <Map<String, dynamic>>[];
+    try {
+      queryResults = await localDatabase.database.rawQuery(
+        getRawQuery(true),
+        <Object>[
+          language.offTag,
+          limit + excludeBarcodes.length,
+        ],
+      );
+    } catch (e) {
+      if (!e.toString().startsWith(
+            'DatabaseException(near "nulls": syntax error (code 1 SQLITE_ERROR[1])',
+          )) {
+        rethrow;
+      }
+      queryResults = await localDatabase.database.rawQuery(
+        getRawQuery(false),
+        <Object>[
+          language.offTag,
+          limit + excludeBarcodes.length,
+        ],
+      );
+    }
 
     final List<String> result = <String>[];