Some bug fixes from my fork #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+361
to
+370
| if vim.o.statusline ~= nil and string.find(vim.o.statusline, "lualine") then | ||
| -- Fix VertSplit & StatusLine crossover when lualine is active | ||
| -- https://github.com/ful1e5/onedark.nvim/issues/2 | ||
| -- https://github.com/hoob3rt/lualine.nvim/issues/274 | ||
| theme.base.StatusLine = { bg = c.bg } | ||
|
|
||
| -- LuaLine | ||
| for _, section in pairs({ "a", "b", "c" }) do | ||
| theme.plugins["lualine_" .. section .. "_inactive"] = inactive | ||
| end |
There was a problem hiding this comment.
Was this the code that you changed in order to fix the inactiveStatusLine still showing a different background?
I just tried this one my local and I'm still seeing the issue. I feel like it's somewhere else in my package. If I use master of your repository it works fine for me but as soon as I switch to mine the status line doesn't hide properly 😭
|
Now fixed |
Comment on lines
+204
to
+209
| -- load syntax for plugins and terminal async | ||
| vim.defer_fn(function() | ||
| util.terminal(theme.colors) | ||
| util.syntax(theme.plugins) | ||
| util.autocmds(theme.config) | ||
| end, 0) |
There was a problem hiding this comment.
This is awesome, I believe this is the fix for the bug! Do you know why this works? I assume it prevents a race condition with overriding the lualine inactive config?
monsonjeremy
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Nested colors overide ful1e5/onedark.nvim#6
Minimal Status Line Bug ful1e5/onedark.nvim#2