feat(everything): Refactoring the way events are read to enable multiple event types #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to support more types of events from GitHub to send notifications. Now we should be able to easily implement new events by adding another file serializer.
What Has Changed:
models/serializers
directory.displayName
,sha
, andmessage
. Therefore, a BaseGithubContext has been created to parse these values further into the application._toMessage()
method used for generating the Slack message previously in GithubPushContext has been moved to the SlackClient to decouple Slack-based functionality from the data classes and increase cohesion._generateMessage()
to_generateSlackMessageFromEvent()
.