Fix infinite loop in has binder #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After running the specs with memwatch probing for leaks, I am content that this change is solid.
This has turned out to be superfluous. `memwatch` does not reveal any memory leaks while running test coverage. Specifications pass. However, the behavior of the equality binder changed, but appears to be logical.
to test the strings example
added a string concat example
Fix has observer for maps
mczepiel
added a commit
to montagestudio/ng-reader
that referenced
this pull request
May 13, 2014
This is from montagejs/frb#44 It has not landed in montage yet but is needed to make filtering work. Without it, the `avoidsEmptySelection` causes an infinite loop when the current article is no longer available in the filtered content presented to the rangeController.
|
This is working well in the example I had where a rangeController's content was changed to a subset of the original content (filtering applied elsewhere); otherwise, the avoidsEmptySelection put us into the aforementioned loop. |
|
@aadsm would you be so kind as to take on the review+merge/maybe? |
|
Still fails on the repetition: |
|
@kriskowal could you rebase on master ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.