Easypost integrate #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubyDiver
force-pushed
the
easypost_integrate
branch
from
a997ec1 to
b87b808
Compare
chytreg
requested changes
Sep 21, 2021
.gitignore
Outdated
| /yarn-error.log | ||
| # Ignore application configuration | ||
| /config/application.yml |
There was a problem hiding this comment.
pls remove it since we don't want to use Figaro
Gemfile
Outdated
| @@ -10,6 +10,8 @@ gem 'pg' | |||
| gem 'sass-rails' | |||
| # Use Uglifier as compressor for JavaScript assets | |||
| gem 'uglifier' | |||
| # Used for locating stores | |||
| gem 'geocoder', '~> 1.6', '>= 1.6.7' | |||
config/initializers/easypost.rb
Outdated
| @@ -0,0 +1,2 @@ | |||
| require 'easypost' | |||
| EasyPost.api_key = 'easypost_API_key' | |||
There was a problem hiding this comment.
Pls take the value of this key from rails credentials!
There was a problem hiding this comment.
pls remove easy_post.rb or easypost.rb only one make sense
.gitignore
Outdated
|
|
||
| /config/master.key | ||
| /config/credentials.yml.enc |
There was a problem hiding this comment.
This file is encrypted and you like to store it in the repository!
https://blog.saeloun.com/2019/10/10/rails-6-adds-support-for-multi-environment-credentials.html
| /config/application.yml | ||
|
|
||
| /config/master.key |
There was a problem hiding this comment.
master.key should be added to some safe place like 1password
| @@ -84,6 +86,7 @@ gem 'spree_i18n', '>= 5.0' | |||
| gem 'spree_multi_vendor', " ~> 2.2" | |||
| gem 'spree_dev_tools', require: false, group: %w[test development] | |||
| gem 'spree_multi_domain', github: 'spree-contrib/spree-multi-domain' | |||
| gem 'spree_easypost', github: 'RubyDiver/spree_easypost' | |||
There was a problem hiding this comment.
Pls add the comment why we have used fork version here
RubyDiver
force-pushed
the
easypost_integrate
branch
from
daff3e4 to
954103a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please, provide here a short description.
Consider including things like:
to achieve the expected result if any
Checklist
Before you move on, make sure that:
WIPlabel to indicate that state