Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Index.js of theme/navbar #1067

Closed
wants to merge 3 commits into from

Conversation

hamidayubdev
Copy link
Contributor

Simplified logic of returning Logo component in theme/navbar/logo/index.js by removing empty early return.

Refactored openMenu function in theme/navbar/index.js.

Copy link

netlify bot commented Jun 29, 2024

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d9567af
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/667f9f8397b4140008e1c67d
😎 Deploy Preview https://deploy-preview-1067--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jun 29, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 86 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 77 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 66 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 68 🟢 95 🟢 100 🟢 100 🟢 100 Report

@andrewnicols andrewnicols requested review from jleyva and dpalou June 29, 2024 05:46
Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but this doesn’t work in all situations.

Our version numbers have three parts and this normalises them to extract just the first two.

@hamidayubdev
Copy link
Contributor Author

hamidayubdev commented Jun 29, 2024

@andrewnicols Which one doesn't work in all situations?
This (refactored getVersion function to directly use versionName ...) commit?

@andrewnicols andrewnicols removed request for jleyva and dpalou June 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants