Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork documentation for Moodle 4.5 #1162

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

junpataleta
Copy link
Collaborator

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4fe3e3d
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/671628aea07ea40008f79181
😎 Deploy Preview https://deploy-preview-1162--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 39 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 56 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 61 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 77 🟢 95 🟢 100 🟢 100 🟢 100 Report

@andrewnicols
Copy link
Member

Note: I haven’t done this because I wanted to check if we should remove the 4.2 docs first to avoid excessive documentation bloat

@junpataleta
Copy link
Collaborator Author

Hi, @andrewnicols. Can't we deal with that on a separate issue instead?

@andrewnicols
Copy link
Member

andrewnicols commented Oct 22, 2024 via email

@HuongNV13 HuongNV13 self-requested a review October 23, 2024 01:58
@HuongNV13
Copy link
Member

Thanks, Jun.
It looks good to me.
Since this PR was built successfully, I guess we can land this and create another PR to remove the 4.2's devdocs

@HuongNV13 HuongNV13 added this pull request to the merge queue Oct 23, 2024
Merged via the queue into moodle:main with commit 6ab86dd Oct 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants