-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add question bank filter API guide #1199
Conversation
❌ Deploy Preview for moodledevdocs failed.
|
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mark. This looks like a good start to documenting this.
Ah! but I see taht the automated checks need to be appeased. |
ce8e3fb
to
606e80b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs look generally great. I've left a few comments -- see what you think.
Since these are docs for a 4.3 feature we should backport to 4.3 and 4.4 using the versioned_docs
folders. If you need help with this I can do this on the PR -- just let me know.
Thanks
6ccef35
to
d7c52b5
Compare
@andrewnicols Thanks for your comments, I have made those changes and re-worked the ordering of things a bit to make it clearer which bits are compulsory, and which are more advanced. I've included those changes as fixups so I can squash them if you're happy. I've also added an extra commit to cover the validation support I've added in MDL-83862. |
@andrewnicols Could you do that |
d7c52b5
to
888b2b5
Compare
This functionality was added in MDL-72321. MDL-78220 will add several new filters, so this guide may expand as the children of that tracker are developed.
f3d73cf
to
24264ad
Compare
Now this has been merged, should it be showing up on the live site or is there there a "release" that we need to wait for? I don't see it here: https://moodledev.io/docs/5.0/apis/plugintypes/qbank |
This functionality was added in MDL-72321. MDL-78220 will add several new filters, so this guide may expand as the children of that tracker are developed.