Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add question bank filter API guide #1199

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

marxjohnson
Copy link
Contributor

This functionality was added in MDL-72321. MDL-78220 will add several new filters, so this guide may expand as the children of that tracker are developed.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for moodledevdocs failed.

Name Link
🔨 Latest commit 24264ad
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6792e8d50715440008ade76f

Copy link
Contributor

github-actions bot commented Dec 3, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 42 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/5.0/apis/commonfiles 🔴 39 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🔴 46 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 50 🟢 95 🟢 100 🟢 100 🟢 100 Report

Copy link
Collaborator

@timhunt timhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark. This looks like a good start to documenting this.

@timhunt
Copy link
Collaborator

timhunt commented Dec 3, 2024

Ah! but I see taht the automated checks need to be appeased.

@marxjohnson marxjohnson force-pushed the question-bank-filters branch 2 times, most recently from ce8e3fb to 606e80b Compare December 3, 2024 15:09
Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs look generally great. I've left a few comments -- see what you think.

Since these are docs for a 4.3 feature we should backport to 4.3 and 4.4 using the versioned_docs folders. If you need help with this I can do this on the PR -- just let me know.

Thanks

@marxjohnson marxjohnson force-pushed the question-bank-filters branch 3 times, most recently from 6ccef35 to d7c52b5 Compare January 9, 2025 15:00
@marxjohnson
Copy link
Contributor Author

@andrewnicols Thanks for your comments, I have made those changes and re-worked the ordering of things a bit to make it clearer which bits are compulsory, and which are more advanced. I've included those changes as fixups so I can squash them if you're happy.

I've also added an extra commit to cover the validation support I've added in MDL-83862.

@marxjohnson
Copy link
Contributor Author

@andrewnicols Could you do that versioned_docs thing you mentioned? I've not done that before I'd be grateful of the help!

@marxjohnson marxjohnson force-pushed the question-bank-filters branch from d7c52b5 to 888b2b5 Compare January 13, 2025 10:42
marxjohnson and others added 3 commits January 24, 2025 09:05
This functionality was added in MDL-72321. MDL-78220 will add several
new filters, so this guide may expand as the children of that tracker
are developed.
@andrewnicols andrewnicols force-pushed the question-bank-filters branch from f3d73cf to 24264ad Compare January 24, 2025 01:11
@andrewnicols andrewnicols added this pull request to the merge queue Jan 24, 2025
Merged via the queue into moodle:main with commit 3959d47 Jan 24, 2025
1 of 7 checks passed
@marxjohnson
Copy link
Contributor Author

Now this has been merged, should it be showing up on the live site or is there there a "release" that we need to wait for? I don't see it here: https://moodledev.io/docs/5.0/apis/plugintypes/qbank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants