Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order the peer review checklist into a more logical order #1213

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

timhunt
Copy link
Collaborator

@timhunt timhunt commented Dec 19, 2024

At least, this seems more logical to me:

  • Move the checkes that are more overall to the end.
  • Group all the UI, and DB/performance together.

Also, add mention of developer_notes label which I always forget.

At least, this seems more logical to me:

* Move the checkes that are more overall to the end.
* Group all the UI, and DB/performance together.

Also, add mention of developer_notes label which I always forget.
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 51115ca
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/67641daefa10360009625e8e
😎 Deploy Preview https://deploy-preview-1213--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@timhunt
Copy link
Collaborator Author

timhunt commented Dec 19, 2024

If this is accespted, then we shold updated the Peer review canned response in the tracker to match.

Copy link

Deploying devdocs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 51115ca
Status: ✅  Deploy successful!
Preview URL: https://e7eff138.devdocs-68g.pages.dev
Branch Preview URL: https://timhunt-peer-review-tidy.devdocs-68g.pages.dev

View logs

Copy link
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 42 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/5.0/apis/commonfiles 🔴 45 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 66 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 60 🟢 95 🟢 100 🟢 100 🟢 100 Report

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @timhunt!
Thanks for sharing this proposal. I agree the order makes more sense and it's also great you improved docs. Well done! <3

@wildgirl could you help us upgrading the canned response in the Tracker with the new order? :-)

@sarjona sarjona added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 13e1ea2 Dec 20, 2024
11 checks passed
@sarjona sarjona deleted the timhunt-peer-review-tidy branch December 20, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants